feat/fix: auto-detect dependencies for foreign managers, make vsce self-contained, and add --no-prepublish#1257
Open
Mopsgamer wants to merge 26 commits into
Open
feat/fix: auto-detect dependencies for foreign managers, make vsce self-contained, and add --no-prepublish#1257Mopsgamer wants to merge 26 commits into
vsce self-contained, and add --no-prepublish#1257Mopsgamer wants to merge 26 commits into
Conversation
Closed
Mopsgamer
marked this pull request as draft
April 4, 2026 19:03
Mopsgamer
marked this pull request as ready for review
April 4, 2026 23:37
This was referenced Apr 5, 2026
Author
BeforeDetailsuser@DESKTOP-NKNOS3C ~/D/G/dracula-highlighting (main)> time node node_modules/vsce/vsce package
DONE Packaged: C:\Users\user\Documents\GitHub\dracula-highlighting\dracula-highlighting-0.1.0.vsix (16 files, 79.47KB)
________________________________________________________
Executed in 3.06 secs fish external
usr time 46.00 millis 0.00 micros 46.00 millis
sys time 15.00 millis 0.00 micros 15.00 millis
user@DESKTOP-NKNOS3C ~/D/G/dracula-highlighting (main)> node node_modules/vsce/vsce pack
Usage: vsce <command>
Options:
-V, --version output the version number
-h, --help display help for command
Commands:
ls [options] Lists all the files that will be published
package [options] [version] Packages an extension
publish [options] [version] Publishes an extension
unpublish [options] [extensionid] Unpublishes an extension. Example extension id: microsoft.csharp.
ls-publishers List all known publishers
delete-publisher <publisher> Deletes a publisher
login <publisher> Add a publisher to the known publishers list
logout <publisher> Remove a publisher from the known publishers list
verify-pat [options] [publisher] Verify if the Personal Access Token has publish rights for the publisher.
show [options] <extensionid> Show extension metadata
search [options] <text> search extension gallery
help [command] display help for command
Unknown command 'pack'.AfterDetailsser@DESKTOP-NKNOS3C ~/D/G/dracula-highlighting (main) [1]> time node ../vscode-vsce/vsce package
INFO Detected presence of bun.lock. Using 'bun' logic.
INFO Files included in the VSIX:
dracula-highlighting-0.1.0.vsix
├─ [Content_Types].xml
├─ extension.vsixmanifest
└─ extension/
├─ LICENSE.txt [1.1 KB]
├─ package.json [1.79 KB]
├─ readme.md [1.74 KB]
├─ assets/
│ └─ icon.png [10.08 KB]
└─ themes/
├─ abyss-dracula.json [58.82 KB]
├─ dark-2026-dracula.json [58.67 KB]
├─ dark-dracula.json [17.61 KB]
├─ dark-high-contrast-dracula.json [58.24 KB]
├─ dark-modern-dracula.json [22.05 KB]
├─ kimbie-dark-dracula.json [58.94 KB]
├─ monokai-dimmed-dracula.json [18.86 KB]
├─ monokai-dracula.json [20.13 KB]
├─ solarized-dark-dracula.json [20.12 KB]
└─ tomorrow-night-blue-dracula.json [58.95 KB]
DONE Packaged: C:\Users\user\Documents\GitHub\dracula-highlighting\dracula-highlighting-0.1.0.vsix (16 files, 79.49 KB)
________________________________________________________
Executed in 1.90 secs fish external
usr time 0.00 millis 0.00 micros 0.00 millis
sys time 31.00 millis 0.00 micros 31.00 millis
user@DESKTOP-NKNOS3C ~/D/G/dracula-highlighting (main)> node ../vscode-vsce/vsce pack
INFO Detected presence of bun.lock. Using 'bun' logic.
INFO Files included in the VSIX:
dracula-highlighting-0.1.0.vsix
├─ [Content_Types].xml
├─ extension.vsixmanifest
└─ extension/
├─ LICENSE.txt [1.1 KB]
├─ package.json [1.79 KB]
├─ readme.md [1.74 KB]
├─ assets/
│ └─ icon.png [10.08 KB]
└─ themes/
├─ abyss-dracula.json [58.82 KB]
├─ dark-2026-dracula.json [58.67 KB]
├─ dark-dracula.json [17.61 KB]
├─ dark-high-contrast-dracula.json [58.24 KB]
├─ dark-modern-dracula.json [22.05 KB]
├─ kimbie-dark-dracula.json [58.94 KB]
├─ monokai-dimmed-dracula.json [18.86 KB]
├─ monokai-dracula.json [20.13 KB]
├─ solarized-dark-dracula.json [20.12 KB]
└─ tomorrow-night-blue-dracula.json [58.95 KB]
DONE Packaged: C:\Users\user\Documents\GitHub\dracula-highlighting\dracula-highlighting-0.1.0.vsix (16 files, 79.49 KB) |
fix: check deno again for missing package.json warn when node_modules is missing
vsce self-contained, and add --no-prepublish
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Refs The ls command does not respect the options in the manifest #1213.I'm not trying to use npm'sarboristhere anymore.libnpmversioninstead of execingnpm version#972.Some issues were prefixed with "fixes", and now they are "refs".
Summary
Fixes:
vsce pack,dependencies(unblocks foreign managers)Features: makes
vsceself-contained,--no-prepublish.100% backward compatibility.
Fixes
vsce pack(aliasing)The problem was the
return Promise.all(promises).then(util.flatten)line. It's replaced withawait + return arr.flat().This problem is real: #1257 (comment)
dependenciesnpm/yarn listtakesdependenciesinto account and uses an auto-detection forundefined.undefinedis an equivalent forauto, it is not set to a boolean value as a fallback.It ensures the flag is enabled automatically when there is a
node_modules/vscodeignore pattern, or a package manager other thannpm/yarn1is detected.Note
Lockfile lookup order and logic can be found in
npm.ts.It's not a resolution algorithm. We are just assuming that users bundle their dependencies and they don't need
node_modulesprod deps in their vsix.dependenciesis used for packaging this directory, so we are simply disabling this option.dependencies: truewill forcenpm/yarn listandnode_modulesprod deps, even if a foreign package manager is detected.Features
vscode:prepublishNew CLI flag,
--no-prepublish, skipsvscode:prepublish.@npmcli/run-scriptreplacesexec(npm run vscode:prepublish)versionBump()exec(npm version)-basedversionBumpimplementation with a 'libnpmversion'-based one to makevsceself-contained.