feat: prompt for full name to confirm unpublish action (#782)#783
Merged
Conversation
joaomoreno
approved these changes
Nov 7, 2022
jrieken
approved these changes
Nov 7, 2022
joaomoreno
enabled auto-merge (squash)
November 7, 2022 11:41
|
🎉 This PR is included in version 2.14.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did some testing on local by using a dummy
package.jsonand this appears to work.Test environments:
Windows 11 | Git Bash | Running
./vscedirectly -> no interactive prompt, does not unpublishWindows 11 | Git Bash | Running with
winpty ./vsce-> interactive prompts, works as expectedWindows 11 | Powershell | Running with
node vsce-> interactive prompts, works as expectedDid not test WSL/Linux or Mac, but I can't imagine the behavior is different.