a few more fixed when compiling with "useDefineForClassFields": true

#243049 and #186726

Author: jrieken

src/vs/workbench/api/common/extHostApiCommands.ts

@@ -60,7 +60,7 @@ const newCommands: ApiCommand[] = [
 				range!: vscode.Range;
 				selectionRange!: vscode.Range;
 				children!: vscode.DocumentSymbol[];
-				override containerName!: string;
+				override containerName: string = '';
 			}
 			return value.map(MergedInfo.to);
 

src/vs/workbench/api/common/extHostDebugService.ts

@@ -63,7 +63,7 @@ export interface IExtHostDebugService extends ExtHostDebugServiceShape {
 
 export abstract class ExtHostDebugServiceBase extends DisposableCls implements IExtHostDebugService, ExtHostDebugServiceShape {
 
-	readonly _serviceBrand: undefined;
+	declare readonly _serviceBrand: undefined;
 
 	private _configProviderHandleCounter: number;
 	private _configProviders: ConfigProviderTuple[];

src/vs/workbench/api/node/extHostDebugService.ts

@@ -31,8 +31,6 @@ import { IExtHostTerminalShellIntegration } from '../common/extHostTerminalShell
 
 export class ExtHostDebugService extends ExtHostDebugServiceBase {
 
-	override readonly _serviceBrand: undefined;
-
 	private _integratedTerminalInstances = new DebugTerminalCollection();
 	private _terminalDisposedListener: IDisposable | undefined;
 

src/vs/workbench/contrib/notebook/browser/diff/diffElementViewModel.ts

@@ -680,8 +680,8 @@ export class SideBySideDiffElementViewModel extends DiffElementCellViewModelBase
 		return this.mainDocumentTextModel;
 	}
 
-	override readonly original!: DiffNestedCellViewModel;
-	override readonly modified!: DiffNestedCellViewModel;
+	declare readonly original: DiffNestedCellViewModel;
+	declare readonly modified: DiffNestedCellViewModel;
 	override readonly type: 'unchanged' | 'modified';
 
 	/**

src/vs/workbench/contrib/notebook/browser/view/notebookCellList.ts

@@ -78,7 +78,7 @@ function validateWebviewBoundary(element: HTMLElement) {
 }
 
 export class NotebookCellList extends WorkbenchList<CellViewModel> implements IDisposable, IStyleController, INotebookCellList {
-	protected override readonly view!: NotebookCellListView<CellViewModel>;
+	declare readonly view: NotebookCellListView<CellViewModel>;
 	private viewZones!: NotebookViewZones;
 	private cellOverlays!: NotebookCellOverlays;
 	get onWillScroll(): Event<ScrollEvent> { return this.view.onWillScroll; }

src/vs/workbench/contrib/terminalContrib/suggest/browser/pwshCompletionProviderAddon.ts

@@ -45,10 +45,12 @@ const enum RequestCompletionsSequence {
 }
 
 export class PwshCompletionProviderAddon extends Disposable implements ITerminalAddon, ITerminalCompletionProvider {
+
+	static readonly ID = 'pwsh-shell-integration';
+
 	id: string = PwshCompletionProviderAddon.ID;
 	triggerCharacters?: string[] | undefined;
 	isBuiltin?: boolean = true;
-	static readonly ID = 'pwsh-shell-integration';
 	readonly shellTypes = [GeneralShellType.PowerShell];
 	private _lastUserDataTimestamp: number = 0;
 	private _terminal?: Terminal;