Notebook webview resources can not be loaded

[rebornix]

Issue Type: Bug

Insiders now always open the notebook webview in iframe and it can't load resources

GET vscode-webview-resource://4250cc26-9639-478b-b277-b6393c61fc34/file///Users/penlv/.vscode-insiders/extensions/ms-vscode.vscode-github-issue-notebooks-0.0.50/dist/renderer.js net::ERR_ABORTED 404 (Not Found)

I'm not able to reproduce this issue in OSS.

VS Code version: Code - Insiders 1.50.0-insider (bc38b0a, 2020-09-11T12:26:02.664Z)
OS version: Darwin x64 19.5.0

System Info

Item	Value
CPUs	Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz (16 x 2400)
GPU Status	2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled metal: disabled_off multiple_raster_threads: enabled_on oop_rasterization: enabled opengl: enabled_on protected_video_decode: unavailable_off rasterization: enabled skia_renderer: disabled_off_ok video_decode: enabled webgl: enabled webgl2: enabled
Load (avg)	3, 3, 3
Memory (System)	32.00GB (0.62GB free)
Process Argv	-psn_0_63487112 --enable-proposed-api ms-vscode.vscode-notebook-history --crash-reporter-id 1a907bbd-fa02-4595-81e0-63e1648afb31
Screen Reader	no
VM	10%

[mjbvz]

Didn't you switch notebooks to always use iframe based webviews a few iterations back?

[rebornix]

@mjbvz no we only tried that temporarily but then continued using electron webview for desktop (by using injected IWebviewService). Insiders from 3 days ago (the last 1.49-Insiders) works fine.

Added a few breakpoints and found that the service registration sequence is now wrong (in Insiders build)

• vscode/src/vs/workbench/contrib/webview/electron-browser/webview.contribution.ts

  Line 12 in 7e5937d

  registerSingleton(IWebviewService, ElectronWebviewService, true);

  is called first

• vscode/src/vs/workbench/contrib/webview/browser/webview.contribution.ts

  Line 33 in 80b1a77

  registerSingleton(IWebviewService, WebviewService, true);

  is then called, which overrides the Electron webview service.

[mjbvz]

Thanks. This was caused by 80b1a77. Not sure how this ever worked or why only notebooks seem effected at the moment but I'll look into a proper fix

[mjbvz]

Pushed potential fix but could not verify since I don't see the bug in OSS. Kicking off an official build now for testing

[mjbvz]

Confirmed that this is fixed for me in the latest insiders