Opening a notebook from markers view is broken

[jrieken]

• open GH issues notebook
• make sure to have some errors
• select an error from the markers view
• 🐛 the cell opens as readonly editor, not as notebook

This happens because an early return here (we have no editor id and the input reports as being untitled). The original input being untitled seems to have changed recently via 183d11a. fyi @bpasero this breaks our assumption and might have more impact in places which aren't known yet.

[jrieken]

fyi @rebornix - there might more usages that only you know of

[bpasero]

@jrieken yeah this was a recent change to allow saving readonly editors. Conceptually readonly editors (coming from virtual document providers) are untitled until you save them. This was a necessary change to handle the transition from saving the editor to opening it again after saving possible.

If you must check for untitled editors that are writeable, looking for untitled: scheme seems legit to me.

When I did this change I checked for all users of isUntitled and did not find issues, though I probably missed this one.

[jrieken]

Optimistically closing