Explore how to indicated read-only and deleted files open in editors more effectively

[miguelsolorio]

Summary

Currently when you open a file and it has been deleted or you open a read-only file, we append the text to the editor tab to indicate this:

This can get busy when you have a lot of tabs open, especially with long names. This issue aims to explore a few different ways that we can visualize this.

Concepts

Option A

One idea is to try and use different seti file icons for this and show the information via tooltip:

Alternatively, we could use codicons to display instead of seti:

Option B

We could use our info icon for read-only and error for deleted:

Option C

Or we simply rely on the decorators to indicate it, we'd need to figure out how to show read-only:

cc @bpasero

[bpasero]

👍 , one interesting aspect of this is that a tab can indicate both readonly and deleted at the same time.

[miguelsolorio]

@mjbvz let me know what the use case is for custom editors and if the "read only" state would still apply or if you're looking for an alternate version

[miguelsolorio]

I'm leaning towards leveraging the existing git decorators and using our custom hovers to display this information (as opposed to the native ones) and swapping to codicons for easier discoverability:

@bpasero thoughts?

[bpasero]

leveraging the existing git decorators

but the decorators are not using red for deletion it seems, probably because that is reserved for showing problems:

Are you suggesting to change decorator color for deletes to show like problems?

Also, are you suggesting to add a new decoration R for the readonly case?

and swapping to codicons for easier discoverability

To clarify, you mean to show an additional icon to the left of the label for conveying the information that the file is deleted or replacing the file icon with it? Also note that user can disable icons.

using our custom hovers to display this

Can you elaborate why this better than the native hover where the same information is displayed?