Skip to content

Fix cut & copy for iPad #101702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 16, 2020
Merged

Fix cut & copy for iPad #101702

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b3fba74
Fix cut & copy for iPad
daybrush Jul 3, 2020
3836119
Merge branch 'master' into cutcopy#101564
daybrush Jul 5, 2020
66592e3
Merge branch 'master' into cutcopy#101564
daybrush Jul 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions src/vs/editor/browser/controller/textAreaHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,14 +178,7 @@ export class TextAreaHandler extends ViewPart {
mode
};
},

getScreenReaderContent: (currentState: TextAreaState): TextAreaState => {

if (browser.isIPad) {
// Do not place anything in the textarea for the iPad
return TextAreaState.EMPTY;
}

if (this._accessibilitySupport === AccessibilitySupport.Disabled) {
// We know for a fact that a screen reader is not attached
// On OSX, we write the character before the cursor to allow for "long-press" composition
Expand Down
7 changes: 0 additions & 7 deletions src/vs/editor/test/browser/controller/imeTester.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
* Licensed under the MIT License. See License.txt in the project root for license information.
*--------------------------------------------------------------------------------------------*/

import * as browser from 'vs/base/browser/browser';
import { createFastDomNode } from 'vs/base/browser/fastDomNode';
import { ITextAreaInputHost, TextAreaInput } from 'vs/editor/browser/controller/textAreaInput';
import { ISimpleModel, PagedScreenReaderStrategy, TextAreaState } from 'vs/editor/browser/controller/textAreaState';
Expand Down Expand Up @@ -96,12 +95,6 @@ function doCreateTest(description: string, inputStr: string, expectedStr: string
};
},
getScreenReaderContent: (currentState: TextAreaState): TextAreaState => {

if (browser.isIPad) {
// Do not place anything in the textarea for the iPad
return TextAreaState.EMPTY;
}

const selection = new Range(1, 1 + cursorOffset, 1, 1 + cursorOffset + cursorLength);

return PagedScreenReaderStrategy.fromEditorSelection(currentState, model, selection, 10, true);
Expand Down