Reduces flickering of inline completions & fixes context key. #125654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Pending update operations are cleared immediately (and not debounced). * Context Key is updated when suggest widget becomes inactive. * Suggest Widget only becomes inactive after an 100ms timeout. * Leading whitespace is only ignored when the inline completion is about indentation.
hediet
commented
Jun 7, 2021
|
|
||
| // This delay fixes an suggest widget issue when typing "." immediately restarts the suggestion session. | ||
| private setInactiveDelayed = this._register(new RunOnceScheduler(() => { | ||
| if (!this.isSuggestWidgetVisible) { |
There was a problem hiding this comment.
We only reset active if the suggest widget is not visible anymore (i.e. if it became invisible and then visibile again in the meantime).
alexdima
approved these changes
Jun 7, 2021
|
(Just stopping in to say thank you for the usability and UI fixes you've authored over the last couple of weeks! 😄✨ ) |
|
Thank you! Alex has helped me a lot though 😀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pending update operations are cleared immediately (and not debounced).
This prevents a stale cache when the update operation finishes.
Context Key is updated when suggest widget becomes inactive.
This fixes that "tab" does not always work to accept a suggestion.
Suggest Widget only becomes inactive after an 100ms timeout.
This fixes flickering when typing
windowand then., which closes the suggest widget but opens it again immediately.Leading whitespace is only ignored when the inline completion is about indentation.
This fixes an issue when the user types a whitespace after a suggestion that has an empty replace range.
Cache is disposed when no command is set.