Adds a way for web projects which have defined their TS version to get a full tsserver #138621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t a full tsserver
|
Have you noticed any issues running the full TS Server on web? Any reason we'd not make it the default? |
|
Heh, I got this up and running and it just stays in initializing:
There's no obvious logs nor TSServer results, so I'll need to do some tracing to figure out what's going on 👍🏻 |
|
Closing as out of date but let me know if this is something we want to revisit |
|
I think tsserver plugins on web pretty much deprecate this |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relies on #138211 - the central idea is that if you have set a ts sdk locally in your web project (instead of the default build) then you know what you're doing enough to get the full-fat TSServer implementation.