Skip to content

[release/1.71] Disables the canvas renderer on Safari #160332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Sep 7, 2022

Fixes #160070


A runtime crash can occur in the canvas renderer in Safari which causes rendering glitches. This is a quick fix that just disables the renderer in the release branch, the real fix is in xterm.js which isn't ideal for recovery releases.

@Tyriar Tyriar added this to the August 2022 Recovery 2 milestone Sep 7, 2022
@Tyriar Tyriar requested a review from meganrogge September 7, 2022 17:16
@Tyriar Tyriar self-assigned this Sep 7, 2022
@fritterhoff fritterhoff mentioned this pull request Sep 8, 2022
25 tasks
@Tyriar Tyriar added the candidate Issue identified as probable candidate for fixing in the next release label Sep 13, 2022
@Tyriar Tyriar merged commit 22ed3b2 into release/1.71 Sep 13, 2022
@Tyriar Tyriar deleted the tyriar/r_1_71_160070 branch September 13, 2022 20:04
@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
candidate Issue identified as probable candidate for fixing in the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants