Skip to content

Sign PowerShell scripts on Windows #243931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2025
Merged

Sign PowerShell scripts on Windows #243931

merged 1 commit into from
Mar 19, 2025

Conversation

karthiknadig
Copy link
Member

@karthiknadig karthiknadig commented Mar 19, 2025 •
edited
Loading

Fixes #174021

These are the files that are found and signed at this time:

\resources\app\out\vs\workbench\contrib\terminal\common\scripts\shellIntegration.ps1
\resources\app\extensions\terminal-suggest\scripts\update-specs.ps1
\resources\app\extensions\terminal-suggest\scripts\clone-fig.ps1

image

@karthiknadig karthiknadig self-assigned this Mar 19, 2025
@karthiknadig karthiknadig changed the title Sign powershell scripts Sign PowerShell scripts on Windows Mar 19, 2025
@karthiknadig karthiknadig marked this pull request as ready for review March 19, 2025 02:40
@karthiknadig karthiknadig enabled auto-merge (squash) March 19, 2025 02:41
@vs-code-engineering vs-code-engineering bot added this to the March 2025 milestone Mar 19, 2025
Tyriar
Tyriar approved these changes Mar 19, 2025
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@karthiknadig karthiknadig merged commit c7a52b8 into main Mar 19, 2025
17 checks passed
@karthiknadig karthiknadig deleted the kanadig/pwsh-signing branch March 19, 2025 09:46
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators May 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tyriar Tyriar Tyriar approved these changes

@joaomoreno joaomoreno Awaiting requested review from joaomoreno

Assignees

@karthiknadig karthiknadig

Labels
None yet
Projects
None yet
Milestone
March 2025
Development

Successfully merging this pull request may close these issues.

shellIntegration.ps1 is not digitally signed
2 participants
@karthiknadig @Tyriar