refactor: setup errorTelemetry from electron-main #244020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpasero
approved these changes
Mar 19, 2025
There was a problem hiding this comment.
This is reasonable and I wonder why we never did this before (cc @lramos15) maybe just an oversight.
The one disadvantage this brings is that exceptions in the main process are not really visible anymore to devs because we mainly have the renderer dev console visible, though maybe with F5 debugging this changed anyway.
|
Will merge in its current state and follow-up based on feedback. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for #241390
Currently errors from electron-main are sent to the focused window via
vscode:reportErrorchannel to forward them to error telemetry. However, we also would like to send error telemetry for unresponsive windows in which case we need the capability to send telemetry from main process.