Skip to content

Make TestAssets.sln buildable locally #15466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nohwnd merged 1 commit into from
Mar 9, 2026
+8 −0
Merged

Make TestAssets.sln buildable locally #15466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions test/TestAssets/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,5 +32,10 @@
<LangVersion>Latest</LangVersion>
</PropertyGroup>

<PropertyGroup>
<_LocalVSTestPackagesDirectory>$(RepoRoot)artifacts/packages/$(Configuration)/Shipping</_LocalVSTestPackagesDirectory>
<RestoreAdditionalProjectSources Condition="Exists('$(_LocalVSTestPackagesDirectory)')">$(RestoreAdditionalProjectSources);$(_LocalVSTestPackagesDirectory)</RestoreAdditionalProjectSources>
</PropertyGroup>

<Import Project="$(RepoRoot)eng/Versions.props" />
</Project>
3 changes: 3 additions & 0 deletions test/TestAssets/Directory.Build.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,7 @@
<!-- We don't want these projects to be Arcade projects, because they are
test projects for testing, and most people don't use Arcade, so we don't want the details of
arcade to go into them. -->
<PropertyGroup>

Copilot AI Mar 9, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting PackageVersion unconditionally will override the version set by the integration test infrastructure (via Build.cs) when the tests are run in CI. This property should only be set when a local build is detected, for example by conditioning on whether the local packages directory exists or on a property that indicates a local build, similar to the condition used in Directory.Build.props for RestoreAdditionalProjectSources. Without a condition, CI builds may end up using the wrong package version.

Suggested change
<PropertyGroup>
<PropertyGroup Condition="'$(IsLocalBuild)' == 'true'">

Copilot uses AI. Check for mistakes.
<PackageVersion>$(Version)-dev</PackageVersion>
</PropertyGroup>
</Project>