Dynamic corelib.net loading (#2762) #2803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* First working version, * Calling async method, * Cleaning code, * Reverting changes, * Fixing test, * Copy to output required libs to fix tests * Next fix Co-authored-by: Jakub Chocholowicz <[email protected]>
fhnaseer
requested review from
Haplois and
jakubch1
and removed request for
Haplois
jakubch1
approved these changes
Mar 8, 2021
Haplois
approved these changes
Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First working version,
Calling async method,
Cleaning code,
Reverting changes,
Fixing test,
Copy to output required libs to fix tests
Next fix
Co-authored-by: Jakub Chocholowicz [email protected]
Description
Please add a meaningful description for this change.
Ensure the PR has required unit tests.
Related issue
Kindly link any related issues. E.g. Fixes #xyz.