Skip to content

Remove process suspend #4586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nohwnd merged 2 commits into from
Aug 4, 2023
Merged

Remove process suspend #4586

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0310bb0
Remove process suspend
nohwnd Jun 30, 2023
5451a34
Merge branch 'main' into remove-process-suspend
nohwnd Aug 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 5 additions & 37 deletions src/Microsoft.TestPlatform.Extensions.BlameDataCollector/ProcessCodeMethods.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@ public static void Suspend(this Process process)

if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
{
SuspendWindows(process);
// There is no supported or documented API to suspend a process. If there was you should call it here.
// SuspendWindows(process);
}
else
{
Expand Down Expand Up @@ -70,40 +71,6 @@ public static List<ProcessTreeNode> GetProcessTree(this Process process)
return new List<ProcessTreeNode> { new ProcessTreeNode { Process = process, Level = 0 } }.Concat(acc.Where(a => a.Level > 0)).ToList();
}

internal static void SuspendWindows(Process process)
{
EqtTrace.Verbose($"ProcessCodeMethods.Suspend: Suspending process {process.Id} - {process.ProcessName}.");
NtSuspendProcess(process.Handle);
}

internal static void SuspendLinuxMacOs(Process process)
{
try
{
var output = new StringBuilder();
var err = new StringBuilder();
Process ps = new();
ps.StartInfo.FileName = "kill";
ps.StartInfo.Arguments = $"-STOP {process.Id}";
ps.StartInfo.UseShellExecute = false;
ps.StartInfo.RedirectStandardOutput = true;
ps.OutputDataReceived += (_, e) => output.Append(e.Data);
ps.ErrorDataReceived += (_, e) => err.Append(e.Data);
ps.Start();
ps.BeginOutputReadLine();
ps.WaitForExit(5_000);

if (!err.ToString().IsNullOrWhiteSpace())
{
EqtTrace.Verbose($"ProcessCodeMethods.SuspendLinuxMacOs: Error suspending process {process.Id} - {process.ProcessName}, {err}.");
}
}
catch (Exception ex)
{
EqtTrace.Verbose($"ProcessCodeMethods.GetParentPidMacOs: Error getting parent of process {process.Id} - {process.ProcessName}, {ex}.");
}
}

/// <summary>
/// Returns the parent id of a process or -1 if it fails.
/// </summary>
Expand Down Expand Up @@ -248,6 +215,7 @@ private static extern int NtQueryInformationProcess(
int processInformationLength,
out int returnLength);

[DllImport("ntdll.dll", SetLastError = true)]
private static extern IntPtr NtSuspendProcess(IntPtr processHandle);
// This call is undocumented api, and should not be used.
//[DllImport("ntdll.dll", SetLastError = true)]
//private static extern IntPtr NtSuspendProcess(IntPtr processHandle);
}