Skip to content

feat!: stack-based format buffer for wdk crate #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leon-xd merged 33 commits into from
Apr 17, 2026
Merged

feat!: stack-based format buffer for wdk crate #611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
fb1c4ef
merged changes from accidental copilot branch
Feb 12, 2026
2c1c9a3
passing cargo fmt
Feb 12, 2026
e065e50
passing cargo clippy stable
Feb 12, 2026
704fc5b
added gated compilation for fmt
Feb 12, 2026
bc15583
removed redundant import
Feb 13, 2026
8e5f834
fix print!/println! docs to match stack-buffer implementation
Feb 19, 2026
74a4e88
fix doctest path to use public re-export
Feb 19, 2026
b96937d
use full path for WdkFormatBuffer in _print
Feb 19, 2026
6a9c1e6
Addressed PR comments
Feb 24, 2026
7a64ee9
make as_cstr infallible, enforce N>0 at compile time
Feb 25, 2026
63fa51f
add WdkFlushableFormatBuffer for chunked output
Feb 26, 2026
7ac5a2a
fix type inference for WdkFlushableFormatBuffer in _print
Feb 26, 2026
1ccaf48
remove alloc gate from print for WDM/KMDF
Feb 26, 2026
5dfe309
Merge remote-tracking branch 'microsoft/main' into generic-stack-alloc
Feb 27, 2026
82e816b
require N >= 2 for WdkFormatBuffer to prevent infinite loop
Feb 27, 2026
fb93fa5
Update crates/wdk/src/print.rs
leon-xd Feb 27, 2026
a028613
addressed CR comments
Mar 10, 2026
7a956a7
added drop, renamed vars and functions
Mar 11, 2026
bc4e1e3
removed clearing buffer
Mar 11, 2026
eaac85e
remove driver_model gate from fmt module
Mar 16, 2026
1bf05b1
fix _print doc comment to reflect UMDF NUL byte handling
Mar 16, 2026
2aea525
Merge remote-tracking branch 'microsoft/main' into generic-stack-alloc
Mar 19, 2026
0c40024
address CR: rename types, fix borrow errors, clippy
Mar 31, 2026
d6ee8a7
refactor: extract append_bytes, remove dead alloc feature, improve Debug
Mar 31, 2026
d20b544
test: merge test modules, use nested sub-modules
Apr 1, 2026
d64171a
address copilot review: narrow as_c_str scan, use constant in test, f…
Apr 1, 2026
a9b9a1b
Merge branch 'main' into generic-stack-alloc
leon-xd Apr 1, 2026
940410e
Merge branch 'main' into generic-stack-alloc
leon-xd Apr 15, 2026
0ac4bc9
address PR review comments from wmmc88
Apr 15, 2026
9d9fb65
bump MSRV to 1.87, reuse self.flush() in write_str
Apr 16, 2026
37ee393
use derive(Clone) for FormatBuffer
Apr 16, 2026
12636e6
fix MSRV to 1.91 (floor_char_boundary)
Apr 16, 2026
bfc706d
Merge microsoft/main into generic-stack-alloc
Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ cargo make wdk-pre-commit-flow
- **FFI naming:** Bindings in `wdk-sys` retain their original C names and style (e.g., PascalCase functions). Safe Rust wrappers in `wdk` follow [Rust naming conventions (RFC 430)](https://rust-lang.github.io/api-guidelines/naming.html).
- **Formatting:** `rustfmt` uses nightly-only unstable options (see `rustfmt.toml`). Import grouping is `StdExternalCrate`, granularity is `Crate`.
- **Lints:** Clippy `all` is deny, `pedantic`/`nursery`/`cargo` are warn. Most workspace members inherit `[lints] workspace = true`; `wdk-sys`, `wdk-build`, `wdk-macros`, and `cargo-wdk` define their own `[lints]` tables instead (Cargo currently does not support both inheriting workspace lints and selectively overriding them per crate).
- **Edition:** 2024, MSRV 1.85.0, resolver v3.
- **Edition:** 2024, MSRV 1.91.0, resolver v3.
- **Static CRT:** Enabled globally via `.cargo/config.toml` (`-C target-feature=+crt-static`).
- **Spelling:** `typos` is configured in `.typos.toml`; Windows API identifiers are allowlisted rather than using file-level excludes.
- **TOML:** `taplo` uses CRLF line endings (see `taplo.toml`).
Expand Down
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ edition = "2024"
license = "MIT OR Apache-2.0"
readme = "README.md"
repository = "https://github.com/microsoft/windows-drivers-rs"
rust-version = "1.85.0"
rust-version = "1.91.0"

[workspace.dependencies]
# Workspace Crates
Expand Down
2 changes: 1 addition & 1 deletion crates/wdk/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ readme.workspace = true
repository.workspace = true

[features]
Comment thread
wmmc88 marked this conversation as resolved.
# Deprecated: no longer required. Kept as a no-op for backward compatibility.
alloc = []
default = ["alloc"]
nightly = ["wdk-sys/nightly"]
Comment thread
leon-xd marked this conversation as resolved.

Comment thread
leon-xd marked this conversation as resolved.
[dependencies]
Expand Down
Loading
Loading