fix(ci): remove the nightly_toolchain feature gate for assert_matches#612
Conversation
…eature=assert_matches)
There was a problem hiding this comment.
Pull request overview
This PR aims to remove the nightly_toolchain feature gate for assert_matches, which is now stable in Rust (stabilized in 1.82.0). The workspace's MSRV is 1.85.0, so this feature should be available without requiring a nightly toolchain. However, the PR is incomplete as it only removes the top-level feature gate but leaves all the conditional compilation guards in place.
Changes:
- Removes the
#![cfg_attr(nightly_toolchain, feature(assert_matches))]attribute from the top ofcrates/wdk-build/src/lib.rs
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #612 +/- ##
=======================================
Coverage 77.41% 77.41%
=======================================
Files 24 24
Lines 4853 4853
Branches 4853 4853
=======================================
Hits 3757 3757
Misses 979 979
Partials 117 117 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…bilization (#643) Fixes `collapsable_if` lint failing in CI pipelines. The `assert_matches` stabilization that was expected to ship with Rust 1.95.0 was [reverted from the 1.95 beta](rust-lang/rust#154999) due to an [inconsistency in temporary scoping behavior](rust-lang/rust#154406) between `assert_matches!`/`assert_eq!` and their `debug_` variants. We gated `assert_matches` usage based on the nightly compiler warning that the feature was "stable since 1.95.0" (see #612). Since the stabilization was reverted before the actual release, this gate now fires on stable 1.95 and tries to use an unstable API, breaking CI pipelines. This bumps the gate to `1.96.0`. Beta 1.96 currently still has `assert_matches` available, though that may change if the destabilization propagates. --------- Co-authored-by: leon-xd <leondu@microsoft.com>
…bilization (microsoft#643) Fixes `collapsable_if` lint failing in CI pipelines. The `assert_matches` stabilization that was expected to ship with Rust 1.95.0 was [reverted from the 1.95 beta](rust-lang/rust#154999) due to an [inconsistency in temporary scoping behavior](rust-lang/rust#154406) between `assert_matches!`/`assert_eq!` and their `debug_` variants. We gated `assert_matches` usage based on the nightly compiler warning that the feature was "stable since 1.95.0" (see microsoft#612). Since the stabilization was reverted before the actual release, this gate now fires on stable 1.95 and tries to use an unstable API, breaking CI pipelines. This bumps the gate to `1.96.0`. Beta 1.96 currently still has `assert_matches` available, though that may change if the destabilization propagates. --------- Co-authored-by: leon-xd <leondu@microsoft.com>
This PR removes the 'nightly_toolchain' feature gate for
assert_matcheswhich is now stable in nightly Rust (since 1.95.0-nightly).