Skip to content

A TryFrom<&str> impl for GUID #3174

Closed

Description

@keehun-cf

Suggestion

Dear windows-rs team,

If I were to contribute a impl TryFrom<&str> for GUID as a pull request, would that be welcomed?

The current impl From<&str> for GUID causes panics on invalid GUID strings which I would like to avoid.

If the windows-rs team does not yet want to introduce Result types, then I'd also be okay with a function that returns Option<GUID>—I'm don't necessarily need a function that returns a Result.

Thank you!

Activity

  1. kennykerr commented on Jul 30, 2024

    @kennykerr
    Collaborator

    There is a Result type provided by the windows-core crate that you can use. Feel free to contribute a TryFrom implementation.

  2. cf-rhett commented on Sep 25, 2024

    @cf-rhett

    Kenny Kerr (@kennykerr) is there documentation on the cadence for which the repo publishes to crates.io. Been hoping to use this for a while but noticed we're still at 0.58.0 on crates.io https://crates.io/crates/windows/versions

  3. kennykerr commented on Sep 25, 2024

    @kennykerr
    Collaborator

    Crates are published as needed to avoid version churn. So there won't be a release unless there's a specific need or request for a specific crate to be updated. Generally developers will test against the repo and when they themselves are ready to publish they will then request a release.

    A good example is today's 0.60.0 release that was requested by rustup after much validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions