Changing openapi refresh flag to false #1350
Conversation
…owershell into Powershell_learning
…owershell into Powershell_learning
timayabi2020
requested review from
peombwa,
ddyett and
shemogumbe
as code owners
tools/UpdateOpenApi.ps1
Outdated
| @@ -39,7 +39,7 @@ $ModuleMapping.Keys | ForEach-Object -Begin { $RequestCount = 0 } -End { Write-D | |||
| $ForceRefresh = $false | |||
| # Check whether ForceRefresh is required, Only required for the First Request. | |||
| if ($RequestCount -eq 0) { | |||
| $ForceRefresh = $true | |||
There was a problem hiding this comment.
@timayabi2020, Is this a temporary change? ForceRefresh is needed to force DevX API to fetch the latest CSDL metadata. Without this, DevX API may serve us a cached version of the CSDL metadata. ForceRefresh is only called once per API version.
There was a problem hiding this comment.
@peombwa yes it is. We need this to atleast prevent the pipeline from failing during beta stage. I was hoping to use test (http://devxapitest.azurewebsites.net/) but it is also not stable. The staging one is also not stable.
There was a problem hiding this comment.
Sounds good! So, we won't merge this PR once the build is complete? This is just to trigger generation of docs.
There was a problem hiding this comment.
Sounds good! So, we won't merge this PR once the build is complete? This is just to trigger generation of docs.
Yes. We won't merge
There was a problem hiding this comment.
@timayabi2020, I've added PR #1371, which allows us to optionally control forceRefresh and base branch from AzDo's UI. We can close this PR and merge #1371.
There was a problem hiding this comment.
Cool. I'll go ahead and close it
Fixes #
This PR is supposed to fix issue #1345
Changes proposed in this pull request
-The image below shows successful downloads with ForceRefresh set to false