-
Notifications
You must be signed in to change notification settings - Fork 192
Proper Success Response Handling #272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
One thing to consider with this as a fix for #271: Making But I think Related: #275 |
Due to COGs concerns, we will not fetch all records from the service by default unless the user explicitly opts-in via |
@ddyett, @darrelmiller, I've updated the PR to address the COGs concerns with fetching all pages by default. With the update made in d4f8797, we will fetch a single page of 100 items by default.
|
This PR closes #110 and #198 by adding
OverrideOnDefault
method onPSCmdlet
. It will ensure cmdlets won't fail when a service returns a success code that's not defined in the OpenAPI coc. TheOverrideOnDefault
will be added to the generated cmdlet at generation time by the directive in readme.graph.md.The generated code will call


OverrideOnDefault
after considering the status code defined in the OpenAPI doc before giving a response a blanket success if its status code is 2xx as shown below.The PR also closes #271 by allowing customers to specify a custom

-PageSize
when iterating through collection of pages as described in #275.Checklist Before Merge
AB#5066
AB#5067