Skip to content

0.7.0 fix #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 15, 2020
Merged

0.7.0 fix #288

merged 7 commits into from
Jul 15, 2020

Conversation

peombwa
Copy link
Member

@peombwa peombwa commented Jul 10, 2020

This PR closes #279 by making the following changes:

  • Default to process cache for app only auth i.e. scripted experience, and user cache file for delegated authentication, device code.
  • Adds-ContextScope enum parameter to Connect-Graph cmdlet. The value can be Process or CurrentUser. This allows customers to opt-out of the default experience.
  • Updates cache locking mechanism to one that's optimized for reads. We expect n-reads and 1 write per hour to the token cache.
  • Adds unit tests to cover process cache.

Proposed Usage

Default
Call App Type Context Scope
Connect-Graph -Scopes "User.Read" Delegated CurrentUser
Connect-Graph -ClientId {Client_ID} -TenantId {Tenant_Id} -CertificateThumbprint {Cert_Thumbprint} App Only Process
With -ContextScope
Call App Type Context Scope
Connect-Graph -ContextScope Process -Scopes "User.Read" Delegated Process
Connect-Graph -ContextScope CurrentUser -ClientId {Client_ID} -TenantId {Tenant_Id} -CertificateThumbprint {Cert_Thumbprint} App Only CurrentUser

Copy link
Contributor

@zengin zengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please let me know what you think about the minor improvements I propose.

@peombwa peombwa merged commit fecfaf3 into master Jul 15, 2020
@peombwa peombwa deleted the po/0.7.1-fix branch July 15, 2020 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants