-
Notifications
You must be signed in to change notification settings - Fork 192
0.7.0 fix #288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
0.7.0 fix #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zengin
reviewed
Jul 14, 2020
zengin
reviewed
Jul 14, 2020
zengin
approved these changes
Jul 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please let me know what you think about the minor improvements I propose.
ddyett
reviewed
Jul 14, 2020
ddyett
reviewed
Jul 14, 2020
ddyett
reviewed
Jul 14, 2020
src/Authentication/Authentication/Extensions/PSCmdletExtensions.cs
Outdated
Show resolved
Hide resolved
ddyett
reviewed
Jul 14, 2020
src/Authentication/Authentication/TokenCache/TokenCacheStorage.cs
Outdated
Show resolved
Hide resolved
ddyett
approved these changes
Jul 14, 2020
…s.cs Co-authored-by: DeVere Dyett <[email protected]>
Co-authored-by: DeVere Dyett <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #279 by making the following changes:
-ContextScope
enum parameter toConnect-Graph
cmdlet. The value can beProcess
orCurrentUser
. This allows customers to opt-out of the default experience.Proposed Usage
Default
Connect-Graph -Scopes "User.Read"
CurrentUser
Connect-Graph -ClientId {Client_ID} -TenantId {Tenant_Id} -CertificateThumbprint {Cert_Thumbprint}
Process
With
-ContextScope
Connect-Graph -ContextScope Process -Scopes "User.Read"
Process
Connect-Graph -ContextScope CurrentUser -ClientId {Client_ID} -TenantId {Tenant_Id} -CertificateThumbprint {Cert_Thumbprint}
CurrentUser