Skip to content

Allow Connect-Graph to take an x509Certificate. #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Nov 18, 2020
Merged

Conversation

georgend
Copy link
Contributor

@georgend georgend commented Oct 22, 2020

Allow Connect-Graph to take an x509Certificate.

Such as:-

$password= "SomePassword"
$passwordSecure = ConvertTo-SecureString -AsPlainText -Force $password

$cert = New-Object System.Security.Cryptography.X509Certificates.X509Certificate2("C:\Certificates\mycert.pfx", $passwordSecure)
Connect-Graph -Certificate $cert -TenantId <some-tenant-id> -ClientId <some-client-id>

Resolves #102

Add tests to verify cert is passed to auth provider.
@georgend georgend requested a review from peombwa October 22, 2020 13:00
@georgend georgend added this to the 1.1.0 milestone Oct 22, 2020
@georgend georgend self-assigned this Oct 22, 2020
@peombwa
Copy link
Member

peombwa commented Oct 22, 2020

@finsharp What does pipeline microsoftgraph.msgraph-sdk-powershell (1) do? It seems to be failing for all PRs. If it's needed, then we should rename it to something useful and figure out why it's failing.

@georgend georgend requested a review from peombwa October 22, 2020 18:40
@georgend georgend requested a review from peombwa October 27, 2020 13:08
peombwa
peombwa previously approved these changes Oct 27, 2020
@ddyett
Copy link
Contributor

ddyett commented Oct 30, 2020

can we add a sample with this usage once approved?

@peombwa
Copy link
Member

peombwa commented Nov 9, 2020

@finsharp The ADO pipelines are failing because we've exhausted our free artifacts storage tier (2 GB). We need to delete old versions of the artifacts then setup a retention policy. See https://docs.microsoft.com/en-us/azure/devops/artifacts/start-using-azure-artifacts?view=azure-devops. Only a feed admin can make these changes.

@darrelmiller darrelmiller modified the milestones: 1.1.0, 1.2.0 Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Connect-Graph authentication via x509 certificate provided in-memory vs. having to be in local machine store on disk
4 participants