Skip to content

Conversation

@folfy
Copy link
Contributor

@folfy folfy commented Nov 4, 2025

Proposal, as highlighted in #411 (comment)

VSCode/devcontainer setup and proxy config

@folfy sorry, as most of us under GFW in china network, we can't directly access github/pip/docker/etc, so we need to config a local mirror about these sites: export APT_MIRROR_DOMAIN=xxxxx, or redirect these domain to proxy.

for windows user, WSL2 should be the expected solution with VScode + devcontainer. install a ubuntu under windows WS2, all these feature should works. finally, I will try to add some info in CONTRIBUTING.md.

Yeah, I already had WSL2 with Ubuntu installed, but still ran into all these issues mentioned above. At least the devcontainer.json should be fixed:
"PIP_MIRROR_DOMAIN": "${localEnv:PIP_MIRROR_DOMAIN:-pypi.org}"
I found out that "localEnv:PIP_MIRROR_DOMAIN" is a docker (compose?) directive to get this from the users environment. Not sure where / how the default value is expanded, but removing the dash after the colon fixes the issue (using the last value as default), so proposing that fix.

Pylint config issue

Unfortunately tests don't seem to run here - I think cause I got some other Pylint error here still, that I didn't bother to investigate before:

Unrecognized option found: suggestion-mode Pylint(E0015:unrecognized-option)

Seems your setting pylintrc:25 suggestion-mode=yes has been deprecated in Pylint 4.0:
https://pylint.readthedocs.io/en/latest/whatsnew/4/4.0/index.html
So I removed that option.

@folfy
Copy link
Contributor Author

folfy commented Nov 4, 2025

-> Rebased onto midea-lan:main (synced with my previous commits for #412 being stashed)

@wuwentao
Copy link
Member

wuwentao commented Nov 5, 2025

thanks for your detail description and info.
merged

@wuwentao wuwentao merged commit 37fdfcf into midea-lan:main Nov 5, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants