Refactor non-admin backup storage location commands #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Joeavaikath
commented
Aug 4, 2025
Joeavaikath
commented
- Introduced new subcommands for managing backup storage location requests: approve, deny, describe, and get.
- Updated the create command to enhance its functionality and examples.
- Improved help text for commands to provide clearer guidance on usage.
- Added tests to ensure help messages are accurate and comprehensive.
- Enhanced the overall structure and organization of the non-admin command set.
This was
linked to
issues
Aug 7, 2025
Closed
Closed
- Introduced new subcommands for managing backup storage location requests: approve, deny, describe, and get. - Updated the create command to enhance its functionality and examples. - Improved help text for commands to provide clearer guidance on usage. - Added tests to ensure help messages are accurate and comprehensive. - Enhanced the overall structure and organization of the non-admin command set.
- Introduced new commands for managing non-admin backup storage location requests: approve, reject, describe, and get. - Updated the create command to support custom credential specifications and improved help text for clarity. - Refactored the Makefile to include new installation options for interactive namespace prompts and default settings. - Removed outdated demo outline documentation to streamline project structure. - Added utility functions for reading client configuration and managing namespaces, improving overall command functionality.
- Introduced a comprehensive suite of integration tests in `integration_test.go` to validate binary build, Makefile installation, client configuration, and command architecture. - Created unit tests for root, non-admin, and NABSL commands to ensure help text accuracy and command functionality. - Enhanced the Makefile to include dedicated targets for running unit and integration tests. - Added a `TESTING.md` document to outline the testing architecture and best practices for future contributions. - Removed outdated test files to streamline the testing structure.
- Added runtime checks for binary creation in `integration_test.go` to support Windows compatibility. - Improved error handling in the Makefile installation test by logging non-fatal errors during cleanup. - Updated the binary path in `testutil.go` to accommodate Windows executable naming conventions. - Removed unnecessary code in `bsl_test.go` to streamline test logic.
- Updated the Makefile to include intelligent detection for OADP deployment namespaces during installation. - Improved help text in the Makefile and README to clarify installation options and the detection process. - Added detailed documentation in README and TESTING.md outlining the automatic detection steps and installation modes. - Ensured fallback mechanisms for namespace detection to enhance user experience.
Joeavaikath
force-pushed
the
nabsl-request
branch
from
4432c94 to
f15b040
Compare
kaovilai
reviewed
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.