Fix keyboard toggle flicker on iOS#466
Merged
migueldeicaza merged 1 commit intomigueldeicaza:mainfrom Feb 12, 2026
Merged
Conversation
Replace resignFirstResponder/becomeFirstResponder cycle with reloadInputViews() wrapped in performWithoutAnimation when switching between the standard keyboard and the custom KeyboardView. This avoids the keyboard dismiss/show animation that causes multiple layout passes and terminal flickering. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
|
Thanks, this looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When toggling between the system keyboard and the custom accessory keyboard on iOS using
iOSAccessoryView, there was a visible flicker. The old code calledresignFirstResponder()+becomeFirstResponder()which triggered a full keyboard dismiss/show animation cycle.Fix
Replace
resignFirstResponder()/becomeFirstResponder()withreloadInputViews(), which swaps the input view in place without dismissing the keyboard. This eliminates the flicker entirely.The change is minimal: just the toggle method in
iOSAccessoryView.swift.