Remove all \rs when reading TESTS.md
#590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`bytestring`'s `lines` does not handle `\r`, and that made the test program not detect enclosing "```"s. This commit treats `\r` explicitly. See: https://hackage.haskell.org/package/bytestring-0.11.3.1/docs/Data-ByteString-Char8.html#v:lines
toku-sa-n
added a commit
to toku-sa-n/hindent
that referenced
this pull request
Aug 24, 2022
After merging mihaimaruseac#590, there should be no errors.
Tests succeeded on the last commit. However, not all tests ran due to `\r`s. This commit removes all `\r`s to run all tests.
Merged
toku-sa-n
changed the title
\rs when reading TESTS.md\rs when reading TESTS.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bytestring'slinesdoes not handle\r, and that made the testprogram not detecting enclosing "```"s. This PR removes all
\rs to prevent the tests from causing theNoFenceEnderror on Windows.