Release: Partially update notebook viewer #2465
Merged
+432
−337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes some formatting issues in the comparison lists under [`nricp_amberg`](https://trimesh.org/trimesh.registration.html#trimesh.registration.nricp_amberg) and [`nricp_sumner`](https://trimesh.org/trimesh.registration.html#trimesh.registration.nricp_sumner) methods in the documentation. To get docs building locally I also had to make some changes to the Makefile and Dockerfile. I'm happy to remove these changes if they're for some reason specific to my environment, or if they'd fit better in a separate PR. ### Before (current): <img width="765" height="495" alt="Screenshot 2025-09-22 at 11 43 56 AM" src="https://github.com/user-attachments/assets/67c57e18-c88f-4e7b-943a-a1d4f590770b" /> ### After (this PR): <img width="750" height="477" alt="Screenshot 2025-09-22 at 11 43 43 AM" src="https://github.com/user-attachments/assets/a0c60fd6-b46b-474d-95f7-ac049f7782d2" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trimesh.resources.viewer.zipartifact. The latest version of three.js is 180 but would require re-factoring the notebook viewer which probably should be done at some point.nricp_amberg/nricp_sumnercomparsion docs #2464BooleanEngineType,BooleanOperationType, andGraphEngineType, and apply them to boolean and graph functions that allow differentengineoptions.repairkeyword argument fromTrimesh.splitto partially fixTrimesh.split()without automatic repair #2460trimesh.viewer.widgetsinceglooeyhasn't been updated since 2021, and the widget module isn't tested.process=Trueon the outputs of manifold3d to fix trimesh merges vertices from manifold3d's output and breaks manifoldness #2466trimesh.path.polygons.sample_polygonis_volumein mesh booleans to fix is_volume check in boolean operations - possible little bug #2458trimesh scipyvstrimesh[easy]