Add optional name parameter to min_distance_internal #2475
Merged
+35
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add optional 'name' parameter to min_distance_internal method - When name=None (default), maintains existing behavior for all object pairs - When name is provided, computes distance from specified object to others - Temporarily removes target object from manager to avoid self-distance calculation - Add test case to verify single object distance functionality
Owner
|
Awesome thanks for the PR!! By any chance did you check the performance of |
mikedh
added a commit
that referenced
this pull request
Nov 24, 2025
- release #2475 - release #2474 - release #2483 - release #2481 - release #2486 - release #2480 - this applies the March 2024 deprecation removing `Trimesh.remove_degenerate_faces` and `Trimesh.remove_duplicate_faces`. - moves the `SceneViewer` control instructions from the README to print on the `h` keypress, and make the default window caption include `h for help` - remove `psutil` from dependencies. It was only used to check if a `scipy.spatial.cdist` call was going to use more than 50% of free system memory before falling back to a more memory-efficient but slower loop. This now falls back to a looping method if the `cdist` call is going to use more than a fixed `4 GB` of memory, - add check that primitives (i.e. `Cylinder`) mostly override `area` and `volume` by checking that their primitive area/volume is not exactly floating point equal to their meshed volume. This caught that `Capsule` didn't return analytical volume/area which was also fixed. We could probably make Primitive a multiple inheritance ABC that requires certain properties but since Primitive already inherits from Trimesh that seems unnecessary and confusing. - clean up references to OpenCTM, which [was deprecated](trimesh/openctm#5) for low use, being unmaintained, and inflicting a burden on upstream package management. - docker images now build with 3.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi again @mikedh! ^^
Here a PR that extends
CollisionManager.min_distance_internal()with an optionalnameparameter to compute distances from a specific object to all others.Changes
name=Noneparameter tomin_distance_internal()nameprovided: computes distance from specified object to othersname=None: existing behavior (all pairs) unchangedUsage