-
-
Notifications
You must be signed in to change notification settings - Fork 702
feat: configure colors of output with env variables #2458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hamskerpir
wants to merge
1
commit into
mikefarah:master
Choose a base branch
from
hamskerpir:pomo/config_colors
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccoVeille
reviewed
Sep 1, 2025
mikefarah
reviewed
Sep 8, 2025
I agree with @ccoVeille comments 👍🏼 |
6f90af1
to
bcc267a
Compare
sorry for long inactivity |
Signed-off-by: mark.barzali <[email protected]>
bcc267a
to
82f3e14
Compare
ccoVeille
reviewed
Sep 8, 2025
Comment on lines
+40
to
+46
for envVar, configField := range colorMappings { | ||
if colorStr := os.Getenv(envVar); colorStr != "" { | ||
if attr, err := parseColorAttribute(colorStr); err == nil { | ||
*configField = attr | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tend to prefer code with less branches
Suggested change
for envVar, configField := range colorMappings { | |
if colorStr := os.Getenv(envVar); colorStr != "" { | |
if attr, err := parseColorAttribute(colorStr); err == nil { | |
*configField = attr | |
} | |
} | |
} | |
for envVar, configField := range colorMappings { | |
colorStr := os.Getenv(envVar) | |
if colorStr == "" { | |
continue | |
} | |
attr, err := parseColorAttribute(colorStr) | |
if err != nil { | |
continue | |
} | |
*configField = attr | |
} |
Also, I feel like it could be frustrating for someone if they try to use an unsupported value, they won't know it failed. I would report the error to user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
my usecase was that color that I was using for my terminal prompt is same that is hardcoded in
yq
, so I've decided add a bit of flexibility to the tool.Unfortunately, I did not find a config structure, and if it does not exist, I think I'm not the person that should set such change in repository :D
Anyway, here is my small changes to configure output via env vars.