generated from actions/typescript-action
-
-
Notifications
You must be signed in to change notification settings - Fork 150
Add pr_id parameter to support PR comments from workflow_run contexts #1379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: mikepenz <[email protected]>
Co-authored-by: mikepenz <[email protected]>
Copilot
AI
changed the title
[WIP] add comment to PR from workflow outside of PR
Add pr_id parameter to support PR comments from workflow_run contexts
Jul 4, 2025
|
||||||||||||||||||||||
|
||||||||||||||||||||||
|
|
|
||||||||||||||||||||||||
1 similar comment
|
||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for commenting on PRs from
workflow_runtriggered workflows, which is essential for handling PRs from external repositories (forks) where the action runs outside the PR context.Problem
When using
workflow_runto handle external PRs (as recommended in the README), thecommentfeature doesn't work becausecontext.issue.numberis not available in the workflow_run context. This prevents users from getting PR comments with test results for external contributions.Solution
Added a new optional
pr_idinput parameter that allows explicitly specifying the PR number to comment on:Key Features
pr_idwhen provided, falls back tocontext.issue.numberChanges Made
pr_idinput parameter toaction.ymlattachComment()function to accept and usepr_idwhencontext.issue.numberis unavailablefindPriorComment()to work with the provided issue numberTesting
All existing tests continue to pass (54 total), plus new tests covering:
Fixes #1378.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.