Implement integer bitwise "and", "or" and "xor" operator. by topikachu · Pull Request #24623 · milvus-io/milvus

topikachu · 2023-06-02T07:51:09Z

Fix #24490
Add bitwise operator in pb definition.
Implement the operator in go and cpp modules.

sre-ci-robot · 2023-06-02T07:51:18Z

Welcome @topikachu! It looks like this is your first PR to milvus-io/milvus 🎉

mergify · 2023-06-02T07:55:54Z

@topikachu ut workflow job failed, comment rerun ut can trigger the job again.

topikachu · 2023-06-02T08:18:02Z

/assign @xiaofan-luan

topikachu · 2023-06-02T10:09:23Z

I run integration tests locally by './scripts/run_intergration_test.sh' without any error. Any idea?

xiaocai2333 · 2023-06-02T10:41:37Z

Great job!
you need to rebase to the latest commit.

topikachu · 2023-06-03T02:53:48Z

Great job! you need to rebase to the latest commit.

The integration test on the master branch fails :(

Could somebody in milvus fix this?

sre-ci-robot · 2023-06-03T11:11:58Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: topikachu
To complete the pull request process, please ask for approval from xiaofan-luan after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

topikachu · 2023-06-03T13:07:54Z

rerun ut

github-actions · 2023-06-03T13:08:08Z

Hello topikachu, you are not in the organization, so you do not have the permission to rerun the workflow, please contact @milvus-io/milvus-maintainers for help.

xiaofan-luan · 2023-06-04T03:33:04Z

UT Reruned

xiaofan-luan · 2023-06-04T03:34:27Z

/assign @xiaocai2333
please help to review the code

mergify · 2023-06-04T03:46:29Z

@topikachu ut workflow job failed, comment rerun ut can trigger the job again.

codecov · 2023-06-04T04:42:22Z

Codecov Report

Attention: 119 lines in your changes are missing coverage. Please review.

Comparison is base (d531b17) 82.64% compared to head (c116a51) 82.12%.
Report is 1618 commits behind head on master.

❗ Current head c116a51 differs from pull request most recent head 217e33b. Consider uploading reports for the commit 217e33b to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #24623      +/-   ##
==========================================
- Coverage   82.64%   82.12%   -0.53%     
==========================================
  Files         776      778       +2     
  Lines      101864   103561    +1697     
==========================================
+ Hits        84185    85045     +860     
- Misses      14670    15488     +818     
- Partials     3009     3028      +19

Files	Coverage Δ
internal/core/src/query/Expr.h	`88.23% <ø> (+1.87%)`	⬆️
internal/parser/planparserv2/operators.go	`95.56% <81.25%> (-0.23%)`	⬇️
internal/parser/planparserv2/parser_visitor.go	`83.27% <57.89%> (-2.48%)`	⬇️
...ternal/core/src/query/visitors/ExecExprVisitor.cpp	`67.16% <0.00%> (-8.60%)`	⬇️

... and 235 files with indirect coverage changes

Fix milvus-io#24490 Add bitwise operator in pb definition. Implement the operator in go and cpp modules. Signed-off-by: gongy <topikachu@163.com>

jiaoew1991 · 2023-06-09T08:11:46Z

Overall, there doesn't seem to be any problem. After running CI, it can be merged ！

mergify · 2023-06-09T08:36:50Z

@topikachu ut workflow job failed, comment rerun ut can trigger the job again.

xiaocai2333 · 2023-06-15T01:41:29Z

@topikachu you need to rebase to the latest commit. and it can be merged.

xiaofan-luan · 2023-06-16T09:05:48Z

sorry for the inconvenience, the code stack is moving very fast

stale · 2023-07-16T09:15:45Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

stale · 2023-08-21T20:32:18Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

stale · 2023-09-21T19:51:37Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

czs007 · 2024-01-14T02:34:25Z

/reopen

mergify · 2024-01-14T02:35:00Z

@topikachu

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

Title Format: The PR title must begin with one of these prefixes:

feat: for introducing a new feature.
fix: for bug fixes.
enhance: for improvements to existing functionality.
test: for add tests to existing functionality.
doc: for modifying documentation.
auto: for the pull request from bot.

Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly

Please review and update your PR to comply with these guidelines.

xiaofan-luan · 2024-01-14T02:38:43Z

@topikachu
Hi Gongyi, would like a discussion on how we can make the pull request in?

mergify · 2024-02-06T02:30:15Z

@topikachu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify · 2024-02-06T02:30:16Z

@topikachu ut workflow job failed, comment rerun ut can trigger the job again.

mergify · 2024-02-06T02:30:16Z

@topikachu

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

Title Format: The PR title must begin with one of these prefixes:

feat: for introducing a new feature.
fix: for bug fixes.
enhance: for improvements to existing functionality.
test: for add tests to existing functionality.
doc: for modifying documentation.
auto: for the pull request from bot.

Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly

Please review and update your PR to comply with these guidelines.

mergify · 2024-03-04T11:31:26Z

@topikachu Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

mergify · 2024-03-05T02:05:40Z

@topikachu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify · 2024-03-05T02:05:40Z

@topikachu ut workflow job failed, comment rerun ut can trigger the job again.

mergify · 2024-03-05T08:27:34Z

@topikachu Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

stale · 2024-04-11T00:05:24Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

sre-ci-robot requested review from czs007 and xiaocai2333 June 2, 2023 07:51

sre-ci-robot added area/internal-api size/XL Denotes a PR that changes 500-999 lines. labels Jun 2, 2023

mergify Bot added the dco-passed DCO check passed. label Jun 2, 2023

sre-ci-robot assigned xiaofan-luan Jun 2, 2023

topikachu force-pushed the bitwise branch from dce827e to c116a51 Compare June 3, 2023 11:11

sre-ci-robot assigned xiaocai2333 Jun 4, 2023

topikachu force-pushed the bitwise branch 2 times, most recently from dbc9b95 to 5a631e1 Compare June 7, 2023 10:19

Implement integer bitwise "and", "or" and "xor" operator.

217e33b

Fix milvus-io#24490 Add bitwise operator in pb definition. Implement the operator in go and cpp modules. Signed-off-by: gongy <topikachu@163.com>

topikachu force-pushed the bitwise branch from 5a631e1 to 217e33b Compare June 8, 2023 08:35

stale Bot added the stale indicates no udpates for 30 days label Aug 21, 2023

xiaofan-luan removed the stale indicates no udpates for 30 days label Aug 22, 2023

stale Bot added the stale indicates no udpates for 30 days label Sep 21, 2023

stale Bot closed this Sep 29, 2023

czs007 reopened this Jan 14, 2024

stale Bot removed stale indicates no udpates for 30 days labels Jan 14, 2024

mergify Bot added the do-not-merge/invalid-pr-format label Jan 14, 2024

mergify Bot added the needs-dco DCO is missing in this pull request. label Mar 4, 2024

mergify Bot added dco-passed DCO check passed. and removed dco-passed DCO check passed. needs-dco DCO is missing in this pull request. labels Mar 4, 2024

mergify Bot added needs-dco DCO is missing in this pull request. and removed dco-passed DCO check passed. labels Mar 5, 2024

stale Bot added the stale indicates no udpates for 30 days label Apr 11, 2024

stale Bot closed this Apr 19, 2024

github-actions Bot mentioned this pull request Mar 9, 2026

🌱 CNCF mission generation 2026-03-09 kubestellar/console-kb#326

Closed

Conversation

topikachu commented Jun 2, 2023

Uh oh!

sre-ci-robot commented Jun 2, 2023

Uh oh!

mergify Bot commented Jun 2, 2023

Uh oh!

topikachu commented Jun 2, 2023

Uh oh!

topikachu commented Jun 2, 2023

Uh oh!

xiaocai2333 commented Jun 2, 2023

Uh oh!

topikachu commented Jun 3, 2023

Uh oh!

sre-ci-robot commented Jun 3, 2023

Uh oh!

topikachu commented Jun 3, 2023

Uh oh!

github-actions Bot commented Jun 3, 2023

Uh oh!

xiaofan-luan commented Jun 4, 2023

Uh oh!

xiaofan-luan commented Jun 4, 2023

Uh oh!

mergify Bot commented Jun 4, 2023

Uh oh!

codecov Bot commented Jun 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

jiaoew1991 commented Jun 9, 2023

Uh oh!

mergify Bot commented Jun 9, 2023

Uh oh!

xiaocai2333 commented Jun 15, 2023

Uh oh!

xiaofan-luan commented Jun 16, 2023

Uh oh!

stale Bot commented Jul 16, 2023

Uh oh!

stale Bot commented Aug 21, 2023

Uh oh!

stale Bot commented Sep 21, 2023

Uh oh!

czs007 commented Jan 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mergify Bot commented Jan 14, 2024

Uh oh!

xiaofan-luan commented Jan 14, 2024

Uh oh!

mergify Bot commented Feb 6, 2024

Uh oh!

mergify Bot commented Feb 6, 2024

Uh oh!

mergify Bot commented Feb 6, 2024

Uh oh!

mergify Bot commented Mar 4, 2024

Uh oh!

mergify Bot commented Mar 5, 2024

Uh oh!

mergify Bot commented Mar 5, 2024

Uh oh!

mergify Bot commented Mar 5, 2024

Uh oh!

stale Bot commented Apr 11, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov Bot commented Jun 4, 2023 •

edited

Loading

czs007 commented Jan 14, 2024 •

edited

Loading