-
Notifications
You must be signed in to change notification settings - Fork 8
Remove estimators #166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove estimators #166
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #166 +/- ##
===========================================
+ Coverage 75.08% 97.77% +22.69%
===========================================
Files 24 23 -1
Lines 1533 1126 -407
===========================================
- Hits 1151 1101 -50
+ Misses 382 25 -357 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I'm a bit confused: PR #167 only restaures a small fraction of the code... maybe it would be gould to already include the next bits ? |
LGTM otherwise |
I separate the modified random forest and the DNN estimator in 2 pull requests. PR #167 is only about the modified random forest and requires a small modification of the random forest from scitkit learn. |
I think it would make sense to prepare the second PR on the DNN estimator before merging that one ? |
This is done in the PR #57. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file examples_not_exhibited/plot_residuals_sampling.py
contains an example showing how to use the modified random forest for conditional sampling. I suggest removing it from the main and adding it to the PR related to the modified RF estimator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx.
933275c
to
b12f917
Compare
For the moment, the estimator are not necessary, they can be added latter.
See #57 and #167