Skip to content

Conversation

@lionelkusch lionelkusch linked an issue Jun 20, 2025 that may be closed by this pull request
@lionelkusch lionelkusch linked an issue Jun 20, 2025 that may be closed by this pull request
@lionelkusch lionelkusch requested a review from bthirion June 23, 2025 13:10
Copy link
Collaborator

@jpaillard jpaillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a personal preference for a more streamlined Readme (see skrub for instance).
But please feel free to ignore my comments if you like a more thorough one.


.. # Add the reference for the badges
.. ## Reference to the CI status
.. |Linter&Tests| image:: https://github.com/mind-inria/hidimstat/actions/workflows/ci.yml/badge.svg?branch=main
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This badge does not render well

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's normal because the name of the workflow is not yet modified.
It will be done with this PR.

Copy link
Collaborator

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx.

@lionelkusch lionelkusch merged commit 5409775 into mind-inria:main Jul 7, 2025
2 of 3 checks passed
@lionelkusch lionelkusch deleted the PR_README.txt branch July 7, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improvement of the Readme. Add acknowledgement to Ebrain-Heanth and ANR VITE projects

3 participants