Skip to content

WMSDK-569: getContext from ReactHost in ActivityCreated callback #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sergeysozinov merged 1 commit into from
Dec 5, 2025
Merged

WMSDK-569: getContext from ReactHost in ActivityCreated callback #135

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 33 additions & 10 deletions android/src/main/java/com/mindboxsdk/MindboxSdkLifecycleListener.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,13 +64,13 @@ internal class MindboxSdkLifecycleListener private constructor(
application: Application,
onReady: (ReactContext) -> Unit
) {
val reactApplication = application.getReactApplication() ?: return
val reactInstanceManager = getReactInstanceManager()

val wrapperListener = object : ReactInstanceManager.ReactInstanceEventListener {
private val called = AtomicBoolean(false)
override fun onReactContextInitialized(context: ReactContext) {
if (called.compareAndSet(false, true)) {
Mindbox.writeLog("[RN] ReactContext initialized (listener)", Level.INFO)
onReady(context)
}
}
Expand All @@ -90,14 +90,19 @@ internal class MindboxSdkLifecycleListener private constructor(
override fun onActivityCreated(activity: Activity, savedInstanceState: Bundle?) {
if (!isMainActivity(activity)) return

getReactInstanceManager()?.currentReactContext?.let {
onReactContextAvailable(it, activity)
Mindbox.writeLog("[RN] ReactContext already available; skipping listener registration ", Level.INFO)
return
}
val hasConsumedReactContext = AtomicBoolean(false)
Copy link
Collaborator

@enotniy enotniy Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а тут не надо вынести в поле класса?

Copy link
Contributor Author

@sergeysozinov sergeysozinov Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не, как раз хорошо оставить локально в onActivityCreated
Она нужна только здесь

И при пересоздании активити она сбросится, а если делать в классе - придется руками сбрасывать


registerReactContextListener(application) { reactContext ->
onReactContextAvailable(reactContext, activity)
if (hasConsumedReactContext.compareAndSet(false, true)) {
onReactContextAvailable(reactContext, activity)
}
}

getReactContext()?.let {
if (hasConsumedReactContext.compareAndSet(false, true)) {
onReactContextAvailable(it, activity)
Mindbox.writeLog("[RN] ReactContext available (pre-existing)", Level.INFO)
}
}
}

Expand Down Expand Up @@ -129,9 +134,7 @@ internal class MindboxSdkLifecycleListener private constructor(
override fun onActivityDestroyed(activity: Activity) {
if (!isMainActivity(activity)) return
subscriber.onEvent(MindboxSdkLifecycleEvent.ActivityDestroyed(activity))
getReactInstanceManager()
?.currentReactContext
?.removeActivityEventListener(activityEventListener)
getReactContext()?.removeActivityEventListener(activityEventListener)
activityEventListener = null
}

Expand All @@ -153,6 +156,26 @@ internal class MindboxSdkLifecycleListener private constructor(

private fun Application.getReactApplication() = this as? ReactApplication

private fun getReactContext(): ReactContext? {
return getReactInstanceManagerContext() ?: getReactHostContext(application)
}

private fun getReactInstanceManagerContext(): ReactContext? {
return getReactInstanceManager()?.currentReactContext
}

private fun getReactHostContext(application: Application): ReactContext? =
runCatching {
// RN 0.78+ moves reactContext from reactNativeHost.reactInstanceManager to reactHost
val reactApplication = application as ReactApplication
val getHostMethod = reactApplication.javaClass.getMethod("getReactHost")
val reactHost = getHostMethod.invoke(reactApplication)
val getContextMethod = reactHost.javaClass.getMethod("getCurrentReactContext")
getContextMethod.invoke(reactHost) as? ReactContext
}.onFailure {
Mindbox.writeLog("[RN] ReactHost currentReactContext unavailable", Level.INFO)
}.getOrNull()

private fun addReactHostListener(
application: Application,
wrapperListener: ReactInstanceManager.ReactInstanceEventListener
Expand Down