Limit datasources to public networks#5391
Merged
evankanderson merged 2 commits intomindersec:mainfrom Feb 3, 2025
Merged
Conversation
JAORMX
reviewed
Feb 1, 2025
internal/datasources/rest/handler.go
Outdated
| if transport == nil { | ||
| transport = rego.LimitedDialer(nil) | ||
| } | ||
| fmt.Printf("transport: %p, tot: %p\n", transport, h.testOnlyTransport) |
eleftherias
approved these changes
Feb 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Only allow datasources to fetch from public services, rather than fetching content from private IP resources.
Change Type
Mark the type of change your PR introduces:
Testing
Unit testing (needed to override tests). This is also in place for
http.sendalready (tested manually).Review Checklist: