Deflake flagged_driver_test by expanding mutex#6062
Merged
JAORMX merged 1 commit intomindersec:mainfrom Jan 24, 2026
Merged
Conversation
evankanderson
force-pushed
the
deflake-1
branch
2 times, most recently
from
66ff072 to
41a97a1
Compare
JAORMX
approved these changes
Jan 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We seem to have a couple frequent flakes on GitHub that don't easily reproduce in my (fast) development environment. Today I decided to try the same thing on a slower machine (4x 1.5Ghz), and was able to reproduce the failures, which seem to be due to flags being reinitialized outside the lock (e.g. "before = 2, after = 0" on an only-incrementing counter must be a reinit).
Testing
5 runs of
go test -count 1000 ./internal/eventswith zero flakes. (about 25 minutes on the aforementioned machine)