Skip to content

Conversation

@micheles
Copy link

This is how the decorator module should be used. Not all tests pass on my machine but I guess I am missing some infrastructure and the problem has nothing to do with my change.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mindflayer
Copy link
Owner

mindflayer commented May 28, 2021

Someone has just opened this issue and it looks like the same problem that makes your tests failing.
I'll have a look at it then I'll merge this PR.
Thanks for the refactor, I like it.

@mindflayer
Copy link
Owner

mindflayer commented Jun 10, 2021

@micheles do you mind merging from my master?

mindflayer added a commit that referenced this pull request Jun 10, 2021
@mindflayer
Copy link
Owner

mindflayer commented Jun 10, 2021

I tried to apply your changes to master in this PR and some tests are still failing, even if I solved the issue related to urllib3.

#153

@mindflayer
Copy link
Owner

Here you can see that now master is able to run all the tests without pinning urllib3:
https://github.com/mindflayer/python-mocket/actions/runs/925082757

@mindflayer
Copy link
Owner

mindflayer commented Jun 16, 2021

I'll try to fix the PR #153 where I applied the patch from yours. I believe it's something related to your refactor which broke the AsyncMocketizer.

@mindflayer mindflayer closed this Jun 16, 2021
@micheles
Copy link
Author

I have no time to look at this now. Let's keep the status quo.

mindflayer added a commit that referenced this pull request Aug 31, 2021
* Patch from PR #150. Thanks to @micheles form the hints.
* Complete refactor for using `decorator>=5`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants