Display next_check_at in the edit feed page #955
Conversation
fguillot
left a comment
fguillot
left a comment
There was a problem hiding this comment.
This pull-request contains unrelated commits. Only changes related to displaying next_check_at value should be present here.
It depends on #938. Could you review #938 firstly please? I still pushed this CL here to let people know that this feature is in progress and I can collect feedback. |
shizunge
force-pushed
the
display-next-check-at
branch
5 times, most recently
from
ad015be to
da9f1f6
Compare
| <div class="panel"> | ||
| <ul> | ||
| <li><strong>{{ t "page.edit_feed.last_check" }} </strong><time datetime="{{ isodate .feed.CheckedAt }}" title="{{ isodate .feed.CheckedAt }}">{{ elapsed $.user.Timezone .feed.CheckedAt }}</time></li> | ||
| <li><strong>{{ t "page.edit_feed.next_check" }} </strong><time datetime="{{ isodate .feed.NextCheckAt }}" title="{{ isodate .feed.NextCheckAt }}">{{ .feed.NextCheckAt }}</time><br />({{ t "page.edit_feed.next_check_note" }})</li> |
There was a problem hiding this comment.
I think it would be better to have this line shown only when the scheduler is configured to entry_frequency. Then the text "page.edit_feed.next_check_note" won't be necessary.
There was a problem hiding this comment.
I am ok to remove the note. (Instead, adding the notes to FAQ or the help)
But I think the next_check_at will still be helpful even when the scheduler is round robin.
If a user sets the polling interval for a single feed (#949), but uses an incompatible global option, they may not get what they want.
There was a problem hiding this comment.
If we keep the next_check_at for all schedulers, the note is relevant. People may ask: why my feed is not fetched at the next_check_at. The note answers that question.
Let me know if you want to keep the notes or not.
Thanks,
Best,
shizunge
force-pushed
the
display-next-check-at
branch
4 times, most recently
from
30551e0 to
1d8cef5
Compare
shizunge
force-pushed
the
display-next-check-at
branch
from
1d8cef5 to
af897d1
Compare
shizunge
force-pushed
the
display-next-check-at
branch
from
af897d1 to
e4d7c6c
Compare
shizunge
force-pushed
the
display-next-check-at
branch
from
e4d7c6c to
4ad5f1e
Compare
|
Closing out-of-sync and inactive pull-requests. Feel free to resubmit this PR as long as you follow the guidelines. |
2 participants
In the edit feed page we have already shown the "last check". Now add next_check_at as well.
This does not complicate the UI, nevertheless this still provides some information to users if they want to debug problems.
issue #699 asks to display the value in the "feeds" page. But I think there is too much information on that page already. So I do not add the value to the "feeds" page.