Skip to content
This repository was archived by the owner on Jun 19, 2025. It is now read-only.

Fix name of application#475

Merged
aead merged 3 commits intominio:masterfrom
ramondeklein:fix-typo
Jul 28, 2024
Merged

Fix name of application#475
aead merged 3 commits intominio:masterfrom
ramondeklein:fix-typo

Conversation

@ramondeklein
Copy link
Contributor

I guess the name of the application should be kes everywhere.

@ramondeklein ramondeklein self-assigned this Jul 15, 2024
@ramondeklein ramondeklein requested a review from aead July 15, 2024 15:25
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, please check the build failures.

Copy link
Member

@harshavardhana harshavardhana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer os.Args[0] but this is acceptable

@ramondeklein
Copy link
Contributor Author

@harshavardhana I do to, but I wanted to bring it inline with the rest of the application. Search for $ kes and there are lots of references. Just wanted to fix this incorrect one.

@ramondeklein
Copy link
Contributor Author

@harshavardhana Can you merge. I'm not allowed to...

@klauspost
Copy link
Contributor

@ramondeklein Seems like CI needs a version bump :/

@ramondeklein
Copy link
Contributor Author

@klauspost I'll know how to do that 😉

@ramondeklein
Copy link
Contributor Author

@klauspost Can you merge?

@ramondeklein
Copy link
Contributor Author

@aead Can you merge?

@aead aead merged commit c1fa6dc into minio:master Jul 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants