This repository was archived by the owner on Jun 19, 2025. It is now read-only.
vault: clone client TLS config and headers for status checks#476
Merged
harshavardhana merged 1 commit intomasterfrom Aug 15, 2024
Merged
vault: clone client TLS config and headers for status checks#476harshavardhana merged 1 commit intomasterfrom
harshavardhana merged 1 commit intomasterfrom
Conversation
This commit improves the Vault status check logic. KES has to clone the Vault client since it has to clear the namespace header for status checks. However, KES should use the same TLS client config and token configured on the client when performing such status checks. KES has to opt-in to this behavior since the Vault SDK doesn't do this by default. Signed-off-by: Andreas Auernhammer <github@aead.dev>
| config := vaultapi.DefaultConfig() | ||
| config.Address = c.Endpoint | ||
| config.CloneTLSConfig = true // Required for status checks | ||
| config.CloneToken = true // Required for status checks |
harshavardhana
approved these changes
Aug 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit improves the Vault status check logic. KES has to clone the Vault client since it has to clear the namespace header for status checks.
However, KES should use the same TLS client config and token configured on the client when performing such status checks. KES has to opt-in to this behavior since the Vault SDK doesn't do this by default.