Use provided sha256 hasher#1749
Merged
Merged
Conversation
Use client provided hasher for SHA256 signatures. By default this is "minio/sha256-simd" or "crypto/sha256" for FIPS. Bonus: Skip tests if env var is missing.
harshavardhana
approved these changes
Jan 10, 2023
harshavardhana
requested changes
Jan 11, 2023
Co-authored-by: Harshavardhana <harsha@minio.io>
Member
|
@klauspost looks like this needs one more fix |
vadmeste
reviewed
Jan 12, 2023
harshavardhana
approved these changes
Jan 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use client provided hasher for SHA256 signatures.
By default this is "minio/sha256-simd" or "crypto/sha256" for FIPS.
Bonus: Skip tests if env var is missing.