feat(#1755): GetObject supports overriding response header values

[reedchan7]

This allows you to pass in the response headers that you need to override when calling the GetObject method.

[klauspost]

Imports missing in the example:

# command-line-arguments
Error: ./getobject-override-respheaders.go:36:19: undefined: minio
Error: ./getobject-override-respheaders.go:37:11: undefined: credentials
Error: ./getobject-override-respheaders.go:41:3: undefined: log
Error: ./getobject-override-respheaders.go:50:9: undefined: minio
Error: ./getobject-override-respheaders.go:55:36: undefined: context
Error: ./getobject-override-respheaders.go:57:3: undefined: log
Error: ./getobject-override-respheaders.go:63:3: undefined: log
Error: ./getobject-override-respheaders.go:69:3: undefined: log
Error: ./getobject-override-respheaders.go:72:15: undefined: io
Error: ./getobject-override-respheaders.go:73:3: undefined: log
Error: ./getobject-override-respheaders.go:73:3: too many errors
Error: make: *** [Makefile:27: examples] Error 1
Error: Process completed with exit code 2.

[reedchan7]

Imports missing in the example:

# command-line-arguments
Error: ./getobject-override-respheaders.go:36:19: undefined: minio
Error: ./getobject-override-respheaders.go:37:11: undefined: credentials
Error: ./getobject-override-respheaders.go:41:3: undefined: log
Error: ./getobject-override-respheaders.go:50:9: undefined: minio
Error: ./getobject-override-respheaders.go:55:36: undefined: context
Error: ./getobject-override-respheaders.go:57:3: undefined: log
Error: ./getobject-override-respheaders.go:63:3: undefined: log
Error: ./getobject-override-respheaders.go:69:3: undefined: log
Error: ./getobject-override-respheaders.go:72:15: undefined: io
Error: ./getobject-override-respheaders.go:73:3: undefined: log
Error: ./getobject-override-respheaders.go:73:3: too many errors
Error: make: *** [Makefile:27: examples] Error 1
Error: Process completed with exit code 2.

Now fixed 👍

[reedchan7]

These codes are in my forked repo, not in v7.0.32, how to resolve this issue? @harshavardhana

[klauspost]

Seems like the replace needs an update: https://github.com/minio/minio-go/blob/master/examples/s3/go.mod#L23

v7.0.10 -> v7.0.32 should sync it back up again. Probably a go mod tidy is needed.

The version isn't important - it should just match the one above.

[reedchan7]

Seems like the replace needs an update: https://github.com/minio/minio-go/blob/master/examples/s3/go.mod#L23

v7.0.10 -> v7.0.32 should sync it back up again. Probably a go mod tidy is needed.

The version isn't important - it should just match the one above.

@klauspost
Replace replace github.com/minio/minio-go/v7 v7.0.10 => ../.. to replace github.com/minio/minio-go/v7 v7.0.10 => github.com/reedchan7/minio-go-sdk/v7 v7.0.48-0.20230116044606-89d027d0d418?
Should this change also need to be merged into the master of minio-go?
Isn't it weird to update the replace to my forked repository?

Althoght, this update got my make examples successful:

Commit: ddac4e5

[klauspost]

@reedchan7 No - you should keep ../.. it replaces it with whatever version it is using. It should be

replace github.com/minio/minio-go/v7 v7.0.32 => ../..

[reedchan7]

@reedchan7 No - you should keep ../.. it replaces it with whatever version it is using. It should be

replace github.com/minio/minio-go/v7 v7.0.32 => ../..

I got it. Thanks 😄

[klauspost]

LGTM. Thanks!