replication: change metrics API

[poornas]

for additional info to be passed back.

[vadmeste]

Few comments

[klauspost]

@poornas Instead of trying to do many small corrections here is my proposal:

// XferStats holds transfer rate for uploads
type XferStats struct {
	// Totals
	Count int64 `json:"count"`
	Bytes int64 `json:"bytes"`

	// Averages - 1 minute?
	AvgBytes  float64 `json:"avgBytes"`
	PeakBytes float64 `json:"peakBytes"`
	CurrBytes float64 `json:"currBytes"`

	AvgCount  float64 `json:"avgCount"`
	PeakCount float64 `json:"peakCount"`
	CurrCount float64 `json:"currCount"`
}

type NodeQueueStats struct {
	Name          string `json:"name"`
	Uptime        int64  `json:"uptime"`
	ActiveWorkers int    `json:"activeWorkers"`
	QueuedCount   int    `json:"queuedCount"`
	QueuedBytes   int64  `json:"queuedBytes"`

	// Transfer statistics For objects larger/smaller than XXXKB.
	Large XferStats `json:"large"`
	Small XferStats `json:"small"`
}

type QueueStats struct {
	Nodes []NodeQueueStats `json:"nodes"`
}

• Groups all small/large values.
• Cuts out "replication" and "repl" from names.
• Adds per node uptime.
• Adds "count" rates.

Still needs more docs.

[poornas]

@poornas Instead of trying to do many small corrections here is my proposal:

Thanks @klauspost , adopted some of the suggestions - the xfer stats refer to rate/sec and different from the in-queue stats, so kept it separate.

[klauspost]

Running lint check
Error: pkg/replication/replication.go:770:6: exported: exported type ReplQNodeStats should have comment or be unexported (revive)
type ReplQNodeStats struct {
     ^
Error: pkg/replication/replication.go:784:6: exported: exported type ReplQueueStats should have comment or be unexported (revive)
type ReplQueueStats struct {
     ^
Error: pkg/replication/replication.go:788:1: exported: exported method ReplQueueStats.Workers should have comment or be unexported (revive)
func (q ReplQueueStats) Workers() int64 {
^
Error: pkg/replication/replication.go:796:6: exported: exported type ReplQStats should have comment or be unexported (revive)
type ReplQStats struct {
     ^
Error: pkg/replication/replication.go:808:1: exported: exported method ReplQueueStats.QStats should have comment or be unexported (revive)
func (q ReplQueueStats) QStats() (r ReplQStats) {
^
Error: pkg/replication/replication.go:844:6: exported: exported type MetricsV2 should have comment or be unexported (revive)
type MetricsV2 struct {
     ^
Error: make: *** [Makefile:15: lint] Error 1

(also some Repl prefixes left).

[klauspost]

LGTM

[harshavardhana]

@poornas PTAL

[vadmeste]

Few comments