HealthCheck: Set initial state#1841
Merged
harshavardhana merged 1 commit intoJun 20, 2023
Merged
Conversation
When starting health checks, do a single check before starting the async health checker to set the initial state of the client. Fixes minio#1840 Also minor bonus, that you cannot accidentally start two if status is offline.
harshavardhana
approved these changes
Jun 19, 2023
poornas
approved these changes
Jun 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When starting health checks, do a single check before starting the async health checker to set the initial state of the client.
Fixes #1840
Also minor bonus, that you cannot accidentally start two if status is offline.