Use default STS endpoint#2044
Merged
harshavardhana merged 2 commits intoJan 3, 2025
Merged
Conversation
ramondeklein
force-pushed
the
use-default-sts-endpoint
branch
from
6decb3f to
17cf994
Compare
harshavardhana
approved these changes
Jan 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
CredentialContextallows to pass the MinIO endpoint to the credential provider. This PR will use the MinIO endpoint as the default STS endpoint if no STS endpoint is specified.I didn't want to break the API, but when we move to MinIO v8, then the
endpointparameter should be removed from functions likecredentials.NewSTSWebIdentity()and it should be passed as an option.