feat: make JSON lib configurable#2088
Merged
Merged
Conversation
harshavardhana
requested changes
Apr 8, 2025
klauspost
reviewed
Apr 8, 2025
klauspost
approved these changes
Apr 9, 2025
Currently, a mix of goccy/json and encoding/json is used. Both use the same interface; goccy/json is faster, however, it also does questionable things with go:linkname. Create a common package that can be switched (via build tags) from one implementation to another, and use that in all packages.
Contributor
Author
|
Pushed a new version to fix the (correct) linter issues about missing comments. |
Contributor
Author
|
@harshavardhana Are there any additional changes you'd like to see for this PR? |
harshavardhana
approved these changes
May 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, a mix of goccy/json and encoding/json is used. Both use the same interface; goccy/json is faster, however, it also does questionable things with go:linkname (problematic with e.g. https://github.com/traefik/yaegi) and has issues with marshaling some structs.
Create a common package that can switch (via build tags) from one implementation to another, and use that in all packages.