Use go tool for ci-lint check#2229
Merged
Merged
Conversation
Script is broken. Instead of downloading and executing a script, use go tool for ci-lint check. Also pins CI check to released versions, etc.
There was a problem hiding this comment.
Pull request overview
This PR updates the project’s linting setup to avoid downloading/executing an external installer script and instead run golangci-lint via Go’s tooling mechanism, while also updating/pinning module dependencies accordingly.
Changes:
- Replace the
curl | shgolangci-lint installation inmake lintwithgo tool golangci-lint run. - Add a
tooldirective forgolangci-lintingo.mod, which pulls in tool-related indirect dependencies. - Update several module versions and regenerate
go.sumto reflect the new dependency graph.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Makefile | Switches lint execution to go tool golangci-lint run, removing the installer-script approach. |
| go.mod | Adds tool directive for golangci-lint and updates/pins dependency versions; introduces many new indirect tool deps. |
| go.sum | Large regeneration reflecting new/updated (mostly tool-driven) dependencies. |
Comments suppressed due to low confidence (2)
Makefile:13
- The previous lint target enforced a 5m timeout; with the current
.golangci.ymlthere is norun.timeoutsetting, sogolangci-lintwill fall back to its default timeout (often 1m) and may fail/flap on slower CI runners. Consider re-adding--timeout=5mhere (or addingrun: { timeout: 5m }to.golangci.ymland keeping this command minimal).
@mkdir -p ${GOPATH}/bin
@echo "Running $@ check"
go tool golangci-lint run
go.mod:30
- This new indirect-require block is entirely tooling-driven (via the
tooldirective) and dramatically increasesgo.modnoise. If you keep thetoolapproach, consider whether these tool-only requires can be isolated (e.g., separate tooling module) so normal consumers don’t carry this dependency surface in their module graph.
require (
4d63.com/gocheckcompilerdirectives v1.3.0 // indirect
4d63.com/gochecknoglobals v0.2.2 // indirect
charm.land/lipgloss/v2 v2.0.3 // indirect
codeberg.org/chavacava/garif v0.2.0 // indirect
codeberg.org/polyfloyd/go-errorlint v1.9.0 // indirect
dev.gaijin.team/go/exhaustruct/v4 v4.0.0 // indirect
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rraulinio
approved these changes
May 18, 2026
ramondeklein
requested changes
May 21, 2026
Contributor
There was a problem hiding this comment.
Please upgrade gomodguard linter in .golangci.yml to gomodguard_v2 to fix warning:
WARN The linter 'gomodguard' is deprecated (since v2.12.0) due to: new major version. Replaced by gomodguard_v2.
WARN Suggested new configuration:
linters:
enable:
- gomodguard_v2
Contributor
Author
|
@ramondeklein Done. |
ramondeklein
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Script is broken. Instead of downloading and executing a script, use go tool for ci-lint check.
Also pins CI check to released versions, etc.
Fixes CI failure: