Export ListObjectV2 to core client#638
Merged
harshavardhana merged 1 commit intoApr 5, 2017
Merged
Conversation
Contributor
nl5887
commented
Apr 4, 2017
nl5887
commented
- needed for gateway
vadmeste
approved these changes
Apr 4, 2017
| type ListBucketV2Result struct { | ||
| // A response can contain CommonPrefixes only if you have | ||
| // specified a delimiter. | ||
| CommonPrefixes []commonPrefix |
Contributor
There was a problem hiding this comment.
CommonPrefixes's type commonPrefix is not exported. Will Go complain when:
prefixes := result.CommonPrefixes
because the type commonPrefix is not exported
Contributor
Author
There was a problem hiding this comment.
I don't think this is a problem. Users won't declare commonPrefix themselves (as they could do with ListBucketV2Result) and Go won't complain about:
prefixes := result.CommonPrefixes
Member
|
ping @nl5887 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.