api/encrypt: Get() on encrypted object should be a readCloser#699
Merged
Conversation
We should implement `io.Closer` for the encryption materials to close the underlying reader whenever a caller requests. GetEncryptedObject() should have returned `io.ReadCloser` in the first place.
harshavardhana
changed the title
harshavardhana
force-pushed
the
cbc-reader
branch
from
914d943 to
cbf2c09
Compare
vadmeste
approved these changes
Jun 2, 2017
Member
|
LGTM and tested. |
4 tasks
Contributor
|
@harshavardhana anything else I can do to help this along? I assume we're just waiting on that final review? |
harshavardhana
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should implement
io.Closerfor the encryption materialsto close the underlying reader whenever a caller requests.
GetEncryptedObject() should have returned
io.ReadCloserin the first place.