Update env vars to meaningful names#713
Merged
Merged
Conversation
Contributor
nitisht
commented
Jun 16, 2017
- Changed environment var S3_ADDRESS to SERVER_ENDPOINT
- Changed environment var S3_SECURE to ENABLE_HTTPS
harshavardhana
previously approved these changes
Jun 16, 2017
Contributor
|
I think it is better to prefix the env vars by MINIO_TEST_ENDPOINT |
Member
Perhaps we can use these consistently across all libraries.. 👍 |
krisis
requested changes
Jun 17, 2017
Member
krisis
left a comment
There was a problem hiding this comment.
Whatever name we pick for environment variables it is best defined as golang constants. I.e,
const (
serverEndpoint = "SERVER_ENDPOINT",
...
)
Contributor
Author
|
Minio SDKs will run against a target that is S3 compatible. So, I thought adding MINIO/S3 will be redundant. @krisis yes, that will be better. I will do it |
- Changed environment var S3_SECURE to ENABLE_HTTPS - Added environment vars as const
Contributor
Author
|
Added constants |
harshavardhana
approved these changes
Jun 20, 2017
krisis
approved these changes
Jun 20, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.